Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple protocol and session levels #25

Open
fjarri opened this issue Oct 13, 2024 · 0 comments
Open

Decouple protocol and session levels #25

fjarri opened this issue Oct 13, 2024 · 0 comments
Assignees
@fjarri
Labels
API Involves backwards-incompatible changes of the public API code quality Making things simpler
Milestone
v1.0.0

Comments

@fjarri
Copy link
Member

fjarri commented Oct 13, 2024 •
edited
Loading

Ideally we would want protocol to know nothing of session. But currently there are several back-references:

  • LocalError and RemoteError are used on both levels. Should we have each layer have their own?
  • EchoRoundError is declared at the session level, but used at the protocol level as one of the variants of ReceiveError
  • protocol/serialization needs to know of WireFormat

Edit: Fixed/invalidated:
@fjarri fjarri added code quality Making things simpler API Involves backwards-incompatible changes of the public API labels Oct 13, 2024
@fjarri fjarri added this to the v1.0.0 milestone Oct 14, 2024
@fjarri fjarri mentioned this issue Oct 22, 2024
Merged
@fjarri fjarri self-assigned this Oct 23, 2024
@fjarri fjarri mentioned this issue Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fjarri fjarri

Labels
API Involves backwards-incompatible changes of the public API code quality Making things simpler
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@fjarri