Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-1213 adds an interceptor to verify the max upload size of each re… #53

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kerruba
Copy link
Contributor

@Kerruba Kerruba commented Sep 24, 2020

…quest and configure it using the file.upload.maxSize property

…quest and configure it using the file.upload.maxSize property
@entando-jx
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: entando-jx

If they are not already assigned, you can assign the PR to them by writing /assign @entando-jx in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

51.9% 51.9% Coverage
0.0% 0.0% Duplication

@w-caffiero-entando w-caffiero-entando changed the title ENG-1213 adds an interceptor to verify the max uplaod size of each re… ENG-1213 adds an interceptor to verify the max upload size of each re… Oct 8, 2020

private boolean isUploadMethod(HttpServletRequest request) {
HttpMethod method = HttpMethod.resolve(request.getMethod());
return HttpMethod.POST.equals(method) || HttpMethod.POST.equals(method);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess this was meant to be POST and PUT
please fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants