Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bugs? #1

Open
amneetb opened this issue Mar 1, 2022 · 1 comment
Open

Possible bugs? #1

amneetb opened this issue Mar 1, 2022 · 1 comment

Comments

@amneetb
Copy link

amneetb commented Mar 1, 2022

@enricoande

[1]

It appears that here phi corresponds to the old state x rather than the new state xp. Is this intentional?

[2]

The function file plotBF.m seems to be missing.

[3]

Q(s,a) = Q(s,a) + alpha * ( r + gamma*Q(sp,ap) - Q(s,a) );

It should be max(Q(sp,:)) instead of Q(sp,ap) for Q-learning as done in the r = -1 case

Q(s,a) = Q(s,a) + alpha * ( r + gamma*max(Q(sp,:)) - Q(s,a) );

@amneetb amneetb changed the title Possible bug? Possible bugs? Mar 1, 2022
@enricoande
Copy link
Owner

Well spotted - I agree with all your comments and they are bugs to be solved. Feel free to make the changes on the branch and submit them to the master.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants