-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added typescript types to allow better integration #54
Conversation
* Added typings to the package. * Update package.json
Thanks @rgolea , this looks good to me. Are there things that need to be addressed before merging this PR? (You've marked it as a Draft) |
@josdejong yeah, for some reason, and I didn't have the time to look better into it (sorry for that), it loses the |
Though I still maintain the library, I have no plans to put effort in If you or someone else create a PR refactoring the library into TS I will be happy to review and merge it though, help would be very welcome. |
I'm starting to refactor everything so I'm closing this PR at the moment. Please, @josdejong let me know if you agree to put it inside a monorepository. I want to use NX for that. I want to fix the typescript issues but also use less polyfills (#30) and allow less instalation for the different packages. Are you okay with having something like: |
@rgolea I hadn't heard of NX before, but I'm ok with that if you think it's a good idea :). I'm curious to see how that will work out. |
@josdejong it's basically Lerna on steroids. The problem I had was that I couldn't expose some internal typings. I decided to go with this to have several packages and this way, we also prevent installing unnecessary parts. I will finish this and I will show you the repo. If you like it, we can proceed with it, if not, we can scratch it off entirely. |
👍 thanks! |
I took a different approach and refactored the whole source to TypeScript and configured |
This should solve #25