Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLA-2069] Fixes publish to dockerhub #54

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

leonardocustodio
Copy link
Contributor

@leonardocustodio leonardocustodio commented Nov 8, 2024

PR Type

configuration changes


Description

  • Updated the GitHub Actions workflow to specify the Dockerfile location during the Docker image build process.
  • This change ensures that the correct Dockerfile is used by adding -f configs/core/Dockerfile to the build command.

Changes walkthrough 📝

Relevant files
Configuration changes
push-image-to-dockerhub.yml
Specify Dockerfile location in Docker build command           

.github/workflows/push-image-to-dockerhub.yml

  • Modified the Docker build command to specify a Dockerfile location.
  • Added -f configs/core/Dockerfile to the build command.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Signed-off-by: Leonardo Custodio <[email protected]>
    Copy link

    github-actions bot commented Nov 8, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @leonardocustodio leonardocustodio changed the title Update push-image-to-dockerhub.yml [PLA-2069] Fixes publish to dockerhub Nov 8, 2024
    @leonardocustodio leonardocustodio self-assigned this Nov 8, 2024
    Copy link

    github-actions bot commented Nov 8, 2024

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Verify the correctness and existence of the Dockerfile path in the docker build command

    Ensure that the Dockerfile path specified in the docker build command is correct and
    exists. If the path is incorrect or the file does not exist, the build will fail.

    .github/workflows/push-image-to-dockerhub.yml [27]

    -docker build -t enjin/$DOCKER_REPOSITORY:$IMAGE_TAG -f configs/core/Dockerfile .
    +docker build -t enjin/$DOCKER_REPOSITORY:$IMAGE_TAG -f [correct/path/to/Dockerfile] .
    Suggestion importance[1-10]: 1

    Why: The suggestion to verify the Dockerfile path is valid but does not directly improve the code. It's more of a cautionary note without a specific actionable change.

    1

    @leonardocustodio leonardocustodio merged commit 70f792b into master Nov 8, 2024
    1 check passed
    @leonardocustodio leonardocustodio deleted the leonardocustodio-patch-1 branch November 8, 2024 21:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Development

    Successfully merging this pull request may close these issues.

    2 participants