Check wallet daemon approval

[enjinabner]

PR Type

enhancement

---

Description

• Enhanced the batch processing logic by introducing a check for collection approval using the CollectionService.
• Modified the logic for determining the source in transfer parameters, utilizing a match expression for better clarity and functionality.
• Added a new import for CollectionService to support the new approval check functionality.

---

Changes walkthrough 📝

	Relevant files
Enhancement	BatchProcess.php Enhance batch processing with collection approval check    src/Commands/BatchProcess.php Added import for CollectionService. Introduced a new variable daemon to store the daemon public key. Modified logic for determining the source in transfer parameters using a match expression. Included a check for collection approval using CollectionService. +7/-3

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Code Clarity The match expression in line 164-168 could be simplified or better documented for clarity. The logic determining the source based on multiple conditions might be confusing without proper comments or simpler structure.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Performance	Improve performance by using dependency injection for CollectionService Replace the resolve function with direct dependency injection for CollectionService in the method signature to improve performance and maintainability. Using dependency injection is more efficient than resolving services in the body of methods. src/Commands/BatchProcess.php [164-168] 'source' => match(true) { - resolve(CollectionService::class)->approvalExistsInCollection($collectionId, $daemon) => $daemon, + $this->collectionService->approvalExistsInCollection($collectionId, $daemon) => $daemon, $daemon !== $claim->collection->owner->public_key => $claim->collection->owner->public_key, default => null }, Suggestion importance[1-10]: 8 Why: The suggestion to use dependency injection instead of the resolve function improves performance and maintainability by making the dependency explicit and reducing runtime overhead.	8
Possible bug	Add null checks to prevent potential runtime errors in the match expression Ensure that the match expression handles potential null values gracefully to avoid runtime errors. Specifically, add a condition to check if the approvalExistsInCollection method returns a non-null value before assigning it. src/Commands/BatchProcess.php [164-168] 'source' => match(true) { - resolve(CollectionService::class)->approvalExistsInCollection($collectionId, $daemon) => $daemon, + $this->collectionService->approvalExistsInCollection($collectionId, $daemon) && $daemon => $daemon, $daemon !== $claim->collection->owner->public_key => $claim->collection->owner->public_key, default => null }, Suggestion importance[1-10]: 7 Why: Adding null checks in the match expression enhances robustness by preventing potential runtime errors, although the original code already handles null values with the default case.	7