[PLA-1780] Ensure Beams can't be claimed from base code when set to Single Use

[v16Studios]

PR Type

Bug fix, Tests

---

Description

• Added a check in CanClaim.php to prevent claiming single-use beams from multi-use codes.
• Introduced a new test in ClaimBeamTest.php to verify that single-use beams cannot be claimed from multi-use codes.

---

Changes walkthrough 📝

	Relevant files
Bug fix	CanClaim.php Prevent claiming single-use beams from multi-use codes.    src/Rules/CanClaim.php Added a check to prevent claiming single-use beams from multi-use codes. Added a condition to fail validation if a single-use beam is detected in a multi-use context. +6/-0
Tests	ClaimBeamTest.php Add test for single-use beam claim from multi-use code.    tests/Feature/GraphQL/Mutations/ClaimBeamTest.php Added a new test to ensure single-use beams cannot be claimed from multi-use codes. Updated imports to include BitMask. +17/-0

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Description updated to latest commit (7ad87a8)

[github-actions]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the PR involves a straightforward bug fix with a small number of changes and includes relevant tests. The logic is not complex, and the changes are localized to specific functionalities.
🧪 Relevant tests	Yes
⚡ Possible issues	No
🔒 Security concerns	No

Code feedback:

---

relevant file	src/Rules/CanClaim.php
suggestion	Consider using a more specific exception or error message to differentiate between general claim failures and the specific case of attempting to claim a single-use beam from a multi-use code. This will enhance debugging and user feedback. [important]
relevant line	$fail('enjin-platform-beam::validation.can_claim')->translate();

---

relevant file	tests/Feature/GraphQL/Mutations/ClaimBeamTest.php
suggestion	Ensure that the signature used in the test is valid or at least resembles a realistic signature rather than using fake()->text(10), which might not represent a valid signature format. This change will make the test more robust and representative of real-world scenarios. [important]
relevant line	'signature' => fake()->text(10),

---

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Error handling	Add error handling for decryption to enhance robustness and error reporting Add error handling for the decryption process to prevent potential runtime errors if the decryption fails. src/Rules/CanClaim.php [40] -$value = explode(':', decrypt($value), 3)[1]; +try { + $decryptedValue = decrypt($value); + $value = explode(':', $decryptedValue, 3)[1]; +} catch (DecryptException $e) { + $fail('enjin-platform-decrypt-failure')->translate(); + return; +} Suggestion importance[1-10]: 10 Why: Adding error handling for the decryption process is crucial for robustness and preventing runtime errors, which can lead to application crashes. This is a significant improvement in terms of error handling and reliability.	10
Security	Add validation to ensure the decrypted value format is as expected to prevent data handling errors Ensure that the decryption and data extraction logic is securely handled, especially when dealing with potentially sensitive data. src/Rules/CanClaim.php [40] -$value = explode(':', decrypt($value), 3)[1]; +$decryptedValue = decrypt($value); +if (!str_contains($decryptedValue, ':')) { + $fail('enjin-platform-invalid-format')->translate(); + return; +} +$value = explode(':', $decryptedValue, 3)[1]; Suggestion importance[1-10]: 9 Why: Adding validation to ensure the decrypted value format is as expected enhances security and prevents potential data handling errors. This is a significant improvement for security and data integrity.	9
Enhancement	Improve the clarity of the exception message for better user feedback Consider using a more specific exception message that indicates the reason for the failure when a single-use beam is claimed from a multi-use code. This will help in debugging and user feedback. src/Rules/CanClaim.php [43] -$fail('enjin-platform-beam::validation.can_claim')->translate(); +$fail('enjin-platform-beam::validation.single_use_claim_attempted')->translate(); Suggestion importance[1-10]: 8 Why: The suggestion improves the clarity of the error message, which can significantly aid in debugging and user feedback. This is a meaningful enhancement for maintainability and user experience.	8
Maintainability	Refactor nested if statements into a more readable format Refactor the nested if statement to improve code readability and maintainability. src/Rules/CanClaim.php [41-46] -} else { - if (BeamService::hasSingleUse($value)) { - $fail('enjin-platform-beam::validation.can_claim')->translate(); - return; - } +} else if (BeamService::hasSingleUse($value)) { + $fail('enjin-platform-beam::validation.can_claim')->translate(); + return; } Suggestion importance[1-10]: 7 Why: The refactoring suggestion improves code readability and maintainability by reducing nesting, which is beneficial for future code modifications and understanding.	7