[PLA-1440] Update probabilities format

[enjinabner]

No description provided.

[github-actions]

PR Analysis

• 🎯 Main theme: Updating the format of probabilities in the ClaimProbabilities class and updating corresponding tests.
• 📝 PR summary: This PR introduces changes to the ClaimProbabilities class in the Beam Support module. It updates the way probabilities are calculated and stored, and also fetches probabilities from the database if they are not found in the cache. The corresponding unit tests are also updated to reflect these changes.
• 📌 Type of PR: Enhancement
• 🧪 Relevant tests added: Yes
• ⏱️ Estimated effort to review [1-5]: 3, because the PR involves changes to both the main code and tests, and requires understanding of the business logic to review effectively.
• 🔒 Security concerns: No security concerns found

PR Feedback

• 💡 General suggestions: The PR seems to be well-structured and follows good coding practices. The changes are well encapsulated within the ClaimProbabilities class and the corresponding tests. However, it would be beneficial to ensure that all edge cases are covered in the tests, especially considering the complexity of the probability calculations.

• 🤖 Code feedback:

  • relevant file: src/Support/ClaimProbabilities.php
    suggestion: Consider handling the case where the total is zero in the computeProbabilities method. Currently, if the total is zero, the method simply returns without doing anything. This could potentially lead to issues downstream where the probabilities are expected to be a certain format. [important]
    relevant line: '+ if (!$total) {'

  • relevant file: src/Support/ClaimProbabilities.php
    suggestion: In the extractTokenIds method, consider adding a check to ensure that the quantity is not zero before calculating the probability. This would prevent potential division by zero errors. [important]
    relevant line: '+ $tokens[$i] = ($count / $total) * 100;'

  • relevant file: src/Support/ClaimProbabilities.php
    suggestion: Consider adding error handling or a fallback mechanism in the getProbabilitiesFromDB method. If the database query fails for any reason, it could lead to unexpected behavior. [medium]
    relevant line: '+ $claims = BeamClaim::selectRaw('

  • relevant file: tests/Unit/ClaimProbabilityTest.php
    suggestion: Consider adding more test cases to cover edge cases and unusual scenarios. This could include cases where the total is zero, or where the quantities are zero. [medium]
    relevant line: '+ public function test_it_can_create_probabilities()'

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

[codecov-commenter]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d6349cc) 96.61% compared to head (ba29b31) 96.66%.

Files	Patch %	Lines
src/Support/ClaimProbabilities.php	98.11%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##             master      #50      +/-   ##
============================================
+ Coverage     96.61%   96.66%   +0.04%     
- Complexity      514      519       +5     
============================================
  Files            84       84              
  Lines          2365     2400      +35     
============================================
+ Hits           2285     2320      +35     
  Misses           80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.