Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLA-1304] Switch Rule to ValidationRule. #39

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

v16Studios
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (f67b61f) 96.99% compared to head (acde00e) 95.68%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
- Coverage     96.99%   95.68%   -1.32%     
+ Complexity      500      493       -7     
============================================
  Files            80       79       -1     
  Lines          2232     2223       -9     
============================================
- Hits           2165     2127      -38     
- Misses           67       96      +29     
Files Coverage Δ
src/Rules/CanClaim.php 100.00% <100.00%> (ø)
src/Rules/HasBeamFlag.php 100.00% <100.00%> (ø)
src/Rules/IsEndDateValid.php 100.00% <100.00%> (ø)
src/Rules/IsStartDateValid.php 100.00% <100.00%> (ø)
src/Rules/MaxTokenCount.php 100.00% <100.00%> (ø)
src/Rules/NotExpired.php 100.00% <100.00%> (ø)
src/Rules/NotOwner.php 100.00% <100.00%> (ø)
src/Rules/NotPaused.php 100.00% <100.00%> (ø)
src/Rules/PassesClaimConditions.php 93.33% <100.00%> (+4.76%) ⬆️
src/Rules/ScanLimit.php 100.00% <100.00%> (ø)
... and 12 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Rules/CanClaim.php Outdated Show resolved Hide resolved
src/Rules/SingleUseCodeExist.php Outdated Show resolved Hide resolved
@v16Studios v16Studios changed the title Switch Rule to ValidationRule. [PLA-1304] Switch Rule to ValidationRule. Sep 29, 2023
src/Rules/IsEndDateValid.php Outdated Show resolved Hide resolved
src/Rules/IsStartDateValid.php Outdated Show resolved Hide resolved
src/Rules/IsStartDateValid.php Outdated Show resolved Hide resolved
@v16Studios v16Studios requested a review from enjinabner October 2, 2023 12:15
@leonardocustodio leonardocustodio merged commit 3ea13df into master Oct 2, 2023
6 checks passed
@leonardocustodio leonardocustodio deleted the feature/pla-1304/switch-to-validation-rule branch October 2, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants