Add transaction hash #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enjinabner
requested review from
tallesborges,
leonardocustodio,
v16Studios and
pawell67
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
============================================
- Coverage 96.98% 96.80% -0.18%
Complexity 499 499
============================================
Files 80 80
Lines 2220 2225 +5
============================================
+ Hits 2153 2154 +1
- Misses 67 71 +4
☔ View full report in Codecov by Sentry. |
pawell67
previously approved these changes
Sep 18, 2023
v16Studios
requested changes
Sep 18, 2023
There was a problem hiding this comment.
While we're at it, should we add the on-chain transaction ID to the data as well? Transaction hashes are a little less reliable as they are purged from the node after about an hour, and as I understand it also aren't necessarily 100% unique per transaction/event, however the on-chain transaction ID is.
v16Studios
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.