[PLA-2080] Check for empty values

[enjinabner]

PR Type

bug_fix

---

Description

• Fixed a potential crash in the getProbabilities method by allowing the code parameter to be nullable and adding a check for empty values.
• Ensured that an empty array is returned when code is empty, preventing further processing and potential errors.

---

Changes walkthrough 📝

	Relevant files
Bug fix	ClaimProbabilities.php Fix crash by handling empty code in getProbabilities          src/Support/ClaimProbabilities.php Modified getProbabilities method to accept nullable string. Added a check for empty code to return an empty array. +2/-2

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Cache Handling Ensure that the cache handling logic correctly manages null or empty 'code' values, especially in terms of cache key generation and data retrieval.

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible bug	Add a check for null or non-string values to prevent type errors Consider adding a check for null or non-string values for code before using it in getCacheKey to prevent potential type errors. src/Support/ClaimProbabilities.php [55-57] -return empty($code) ? [] : Cache::get( +return (is_null($code) || !is_string($code)) ? [] : Cache::get( static::getCacheKey($code), static::getProbabilitiesFromDB($code) ); Suggestion importance[1-10]: 7 Why: The suggestion improves robustness by ensuring that the code variable is not null or a non-string before it is used, which is critical given the method now accepts nullable strings. This prevents potential runtime errors and aligns with the change in the method signature to accept nullable types.	7