Pin Python version used on mybinder.org #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pinning versions of the packages like you do in
requirements.txtit makes sense to also pin the version of Python. This is more an investment in the future, for example when repo2docker (the tool we use to build the repo) switches the default version of Python again.Switching the default version of Python and the very specific pinning of versions is what caused the build to break this time. (We have an issue or forum post on making a guide of best practices but I can't find it :-/). Min's advice in that post goes something like: for "living" repos pin lightly so you can "go with the flow" and get upgrades. Sometimes things will break but as you are using the repo you can fix it then and then. For "archive" repos pin everything. Package versions, their dependencies, and the version of Python. I will try and find the post/issue and link it here.