-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation es #2
base: master
Are you sure you want to change the base?
Conversation
@sebastiandres @labarba I haven't revised the text translation in depth yet. But I have couple of general comments that I think we should address before and have them in mind for future notebooks.
This is what I have for now. If we answer these questions we can start with the changes in the code cells and then move to the details in the text. |
|
On pushing the notebooks with output --- like we did when we were developing the course, we should push without output until all revisions to the content are made. Then push with output at the end. This will keep the diffs more compact. |
@sebastiandres What do you mean when you say " I want to see how the notebooks render". You can check that by picking the right branch in github or the link of the notebook in NBviewer. |
And where would you put the badges? In the README for that particular folder? The language name should probably be in its own language (English, Español, Français). |
I left a proposal here: https://github.com/engineersCode/EngComp1_offtheground/blob/translation_es/LEEME.md |
Updated pull request with reviewed translation for the first 2 notebooks and automated translation for the other notebooks.