Music volume slider asset #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samrocketman
pushed a commit
to samrocketman/endless-sky
that referenced
this pull request
Mar 3, 2023
* This PR is a revival of endless-sky#7538. * Authorship from prior code review is preserved. Feature Summary --------------- Adds the possibility to add playlists to the game that are only played in certain locations and if certain conditions are met. Example: ```ruby track "test2" volume 0.1 #add 0.1 to volume idle "music/mainscreen" #idle track, played during normal gameplay combat "music/mainscreen" #combat track, played during combat landing "music/mainscreen" #landing track, played while landed track "test1" idle "music/haispace" combat "music/haispace" landing "music/haispace" playlist "test" to play #conditions for playing this playlist has "Hai Intro: done" location #locationfilter for where to play this not government "Hai" priority 1 #the priority, higher priority playlist will be chosen over lower priority playlists weight 10 #the weight of a playlist inside of its priority layer, higher weight means more probable to be chosen tracks "linear" "test1" 20 "test2" 20 ``` Detailed Explanation -------------------- `track NAME` holds the following child keys. * `NAME` the name of the track * `volume` (default 0): a value that should be chosen between -1 and 1 that gets added to the current volume of the music. (use this with small values, otherwise users who want dim music will be annoyed.) * Three categories of music associated with this track. The tracks will be played when the player is in their state. If one is not given, nothing will be played in that state. * `idle` * `combat` * `landing` `playlist NAME` holds the following child keys. * `NAME` the name of the playlist. * `to play` conditions that determine if this playlist can be played. * A `location` filter for where this playlist will be played. * A `priority`, higher priorities will always play over lower priorities. * A `weight`, playlists with higher weight are more likely to be played inside the same priority. * `tracks` * A progression style: `linear`, `random`, or `pick` (pick means that one track will be picked and repeated until the playlist is switched) * Various tracks with weights to them, weights only matter for pick or random progression style. This would play either track one or track two when you are not in Hai government zone. Testing Done ------------ TBD Important --------- * Asset pull request: endless-sky/endless-sky-assets#127 Checklist --------- - [ ] Update with upstream master including CMake. - [ ] Do some testing. Co-authored-by: Hurleveur <[email protected]> Co-authored-by: tibetiroka <[email protected]>
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the volume slider svg that works as a base for the volume slider png