Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

타이어 커스텀 페이지 구현 - 측면 디자인 close #23 #24

Merged
merged 8 commits into from
Feb 10, 2024

Conversation

jinlee1703
Copy link
Member

@jinlee1703 jinlee1703 commented Feb 7, 2024

Motivation

Problem Solving

  • 전역 상태 구현 : 측면 디자인 색상, 측면 디자인 글꼴
  • 커스텀 항목 API request를 별도 훅으로 구현
  • 각종 컴포넌트 리팩토링

To Reviewer

Feb-08-2024 07-06-31

image
  • 색상 이미지에서 blue <-> yellow 수정 필요합니다.
  • 색상 data에서 rgb값을 사용하지 않았습니다.
  • 색상이 화면에서 잘 보이지 않아 gray 색상으로 채우기 하였습니다.
  • GIF 캡처 후 선택한 폰트가 UI에서 반영되도록 수정하였습니다.

Copy link
Member

@SubiHwang SubiHwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~!

const [colors, setColors] = useState<ColorData[]>([]);
const [accessories, setAccessories] = useState<AccessoryData[]>([]);
const [selectedPattern] = useRecoilState(selectedPatternIdState);
const [selectedWheel] = useRecoilState(selectedWheelIdState);
const step: number = Number(searchParams.get('step'));

if (step < 0 || step > 3) {
return <div>올바르지 않은 접근입니다.</div>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

올바르지 않은 접근일 때는 어떻게 처리가 되나요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

그냥 빈 화면에 "올바르지 않은 접근입니다."라고 출력돼서 나옵니다~

@jinlee1703 jinlee1703 merged commit 89ce8fb into develop Feb 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants