타이어 만들기 페이지 구현 - 패턴 선택 close #16 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SubiHwang
approved these changes
Feb 6, 2024
| if (subject && !/[^\.] #[0-9]+$/.test(subject)) { | ||
| return [ | ||
| false, | ||
| 'subject는 issue 번호를 #[number] 형식으로 끝에 포함해야하며, .(점) 으로 끝나지 말아야 합니다.', |
There was a problem hiding this comment.
본문의 한 줄은 72자로 제한한다. 와 같은 규칙은 어디에 쓰이는 건가요?
There was a problem hiding this comment.
commit에 header(우리가 -m 옵션을 통해 일반적으로 사용하는 거)말고, body를 통해 commit의 내용을 보다 상세하게 작성할 수 있는데 그 것의 한 줄의 최대 길이를 설정하는 옵션이예요.
우리 팀은 header만 작성하기로 했으니 사실 지장없는 옵션입니다 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Problem Solving
To Reviewers