Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

메인 페이지 -> 커스텀 항목 리스트 페이지 라우팅 구현 #18

Merged
merged 6 commits into from
Jan 30, 2024
Merged

메인 페이지 -> 커스텀 항목 리스트 페이지 라우팅 구현 #18

merged 6 commits into from
Jan 30, 2024

Conversation

jinlee1703
Copy link
Member

Motivation

Problem Solving

  • 기존에는 별도의 페이지로 분리하여 구현하였으니, scroll event가 원활하게 동작하지 않아 하나의 페이지(main > custom-list)로 수정하였음

To Reviewer

  • 동작 화면

    Jan-30-2024 11-28-32

@jinlee1703 jinlee1703 self-assigned this Jan 30, 2024
@jinlee1703 jinlee1703 marked this pull request as ready for review January 30, 2024 02:30
SubiHwang
SubiHwang approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@SubiHwang SubiHwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'smooth'하게 잘 만드셨네요! 수고하셨습니다~

@jinlee1703 jinlee1703 merged commit f476ae3 into develop Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SubiHwang SubiHwang SubiHwang approved these changes

@byeon22 byeon22 Awaiting requested review from byeon22

Assignees

@jinlee1703 jinlee1703

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinlee1703 @SubiHwang