커스텀 항목 페이지 구현 close #14 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byeon22
approved these changes
Jan 29, 2024
| @@ -17,6 +17,7 @@ | |||
| .env.development.local | |||
| .env.test.local | |||
| .env.production.local | |||
| .env | |||
There was a problem hiding this comment.
현재는 API 경로(http://xxx.xxx.xxx.xxx:xxxx) 만 추가해두었습니다~
| getData(); | ||
| }, []); | ||
|
|
||
| console.log(patterns); |
There was a problem hiding this comment.
이거 지워야 하는데
- 패턴 디자인 이미지 Access Denied
- 텍스트 이미지 존재하지 않음
- 색상 이미지 존재하지 않음
이 세 가지 이유로 코드 내에서 사용하지 않고 있어서 컴파일 에러(commitlint & prettier로 인해)가 나는 상황이라 console.log로 강제로 사용하고 있습니다.
다음 PR에 반영해보겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Problem Solving
To Reviewer
구현 화면
패턴 디자인 이미지 Access Denied
텍스트 이미지 존재하지 않음
색상 이미지 존재하지 않음 => 어떻게 구현할 지 결정하지 못하였음