Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

메인 페이지 구현 close #4 #13

Merged
merged 13 commits into from
Jan 25, 2024
Merged

메인 페이지 구현 close #4 #13

merged 13 commits into from
Jan 25, 2024

Conversation

jinlee1703
Copy link
Member

@jinlee1703 jinlee1703 commented Jan 25, 2024

Motivation

Problem Solving

  • Logo 컴포넌트 구현
  • Header 컴포넌트 구현
  • Main 페이지 구현

To Reviewer

  • 구현 결과물입니다.
    image

@jinlee1703 jinlee1703 self-assigned this Jan 25, 2024
@jinlee1703 jinlee1703 marked this pull request as ready for review January 25, 2024 03:04
@jinlee1703 jinlee1703 closed this Jan 25, 2024
@jinlee1703 jinlee1703 reopened this Jan 25, 2024
@jinlee1703 jinlee1703 added main and removed draft labels Jan 25, 2024
Copy link
Member

@SubiHwang SubiHwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컴포넌트를 어떻게 분리했는지에 대한 설계 그림이 있으면 코드를 리뷰하는 데 더 좋을 것 같아요~!

Copy link
Member

@byeon22 byeon22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오~~ 고생하셨습니다~!

@jinlee1703 jinlee1703 merged commit f4e4117 into develop Jan 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants