Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

result post api 생성 close #59 #66

Merged
merged 1 commit into from
Feb 29, 2024
Merged

result post api 생성 close #59 #66

merged 1 commit into from
Feb 29, 2024

Conversation

SubiHwang
Copy link
Member

@SubiHwang SubiHwang commented Feb 23, 2024 •
edited
Loading

Motivation

Problem Solving

  • Controller, Service, responseDTO 코드 작성
  • ResultPostTest 코드 작성

@SubiHwang SubiHwang self-assigned this Feb 23, 2024
jinlee1703
jinlee1703 reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@jinlee1703 jinlee1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

날이 갈수록 이해력이 좋아지는 것 같습니다~ 코드 양이 많아서 힘드셨을텐데 고생많으셨습니다~
테스트 코드 작성까지만 화이팅해봅시다~

byeon22
byeon22 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@byeon22 byeon22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

처음 해보는 POST API라 어려움이 많았을 텐데 고생 많았습니다~~ 수비 화이팅 >..< !!!!

@jinlee1703 jinlee1703 requested a review from byeon22 February 23, 2024 07:42
jinlee1703
jinlee1703 reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@jinlee1703 jinlee1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflict 해결 후 다시 요청해주시면 approve 해드리겠습니다~

src/main/java/com/endlesshorses/oot/custom/result/dto/ResultRequestDto.java Outdated
private Long colorId;
private Long accessoryId;

@Builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P5: actions on save 옵션 켜시면 들여쓰기 자동으로 맞춰줍니다~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵넵!

@byeon22 byeon22 assigned byeon22 and unassigned byeon22 Feb 28, 2024
jinlee1703
jinlee1703 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@jinlee1703 jinlee1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 늦은 밤 고생 많으셨어요~

@SubiHwang SubiHwang marked this pull request as draft February 28, 2024 16:18
@SubiHwang SubiHwang marked this pull request as ready for review February 28, 2024 16:19
@SubiHwang SubiHwang force-pushed the feature#59-result-post-api branch from ffdb2f3 to 0f9c38a Compare February 29, 2024 05:31
@SubiHwang SubiHwang merged commit 4838f74 into develop Feb 29, 2024
1 check passed
@SubiHwang SubiHwang deleted the feature#59-result-post-api branch February 29, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinlee1703 jinlee1703 jinlee1703 approved these changes

@byeon22 byeon22 Awaiting requested review from byeon22

Assignees

@SubiHwang SubiHwang

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SubiHwang @jinlee1703 @byeon22