change image links from public to local #3
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alkarex
added a commit
to alexandrainst/node-red-http-basic-auth
that referenced
this pull request
Oct 12, 2023
Alkarex
added a commit
to alexandrainst/node-red-http-basic-auth
that referenced
this pull request
Oct 12, 2023
* change image links from public to local Apply endemecio02/node-red-contrib-httpauth#3 from @sakazuki * Fix path join * Use Express built-in methods * Minor syntax
|
Hello, @sakazuki Your PR is re-applied (with some modifications) on alexandrainst/node-red-http-basic-auth#5 New node: https://flows.nodered.org/node/@alexandrainst/node-red-http-basic-auth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Thank you for your great work.
I want to avoid getting image files from a public site.
<img src="https://raw.githubusercontent.com/...." />So I patch this.
Currently I can get those image files from local Node-RED admin server(httpAdmin ).
<img src="node-red-contrib-httpauth/..." />