Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

week2 deliverables 100% #4

Closed
wants to merge 25 commits into from
Closed

week2 deliverables 100% #4

wants to merge 25 commits into from

Conversation

cremerf
Copy link
Collaborator

@cremerf cremerf commented Nov 5, 2024

Summary by CodeRabbit

  • New Features

    • Introduced multiple notebooks for managing machine learning experiments, model training, logging, and registration using MLflow.
    • Added a new preprocessing module for hotel reservation data with structured logging.
    • Implemented a CancellationModel class for classification tasks related to hotel cancellations.
    • Created a CancellatioModelWrapper class for handling model predictions with MLflow integration.
  • Bug Fixes

    • Removed unnecessary entries from version control to improve tracking of relevant files.
  • Documentation

    • Added JSON files to document MLflow experiments and model versions for better tracking and management.
  • Chores

    • Updated project configuration and dependencies for improved functionality and compatibility.

@cremerf cremerf requested a review from a team as a code owner November 5, 2024 18:33
Copy link

coderabbitai bot commented Nov 5, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several changes across multiple files, primarily focused on enhancing machine learning workflows using MLflow and Databricks. Key modifications include the addition of new notebooks for managing MLflow experiments, logging, and registering models, as well as updates to configuration files. The .gitignore file has been modified to allow tracking of the prototype directory. Additionally, new JSON files have been created to store experiment and model metadata, and significant updates have been made to existing Python scripts to improve data preprocessing and model management.

Changes

File Path Change Summary
.gitignore Removed entry -prototype, allowing the prototype directory to be tracked by Git.
notebooks/02.mlflow_experiment.ipynb Introduced notebook for managing MLflow experiments, including tracking URI setup, experiment logging, and JSON output.
notebooks/03.log_and_register_model.py Implemented a workflow for logging and registering a machine learning model using LightGBM and MLflow.
notebooks/04.log_and_register_custom_model.py Created a script for training and registering a custom model with MLflow.
notebooks/05.log_and_register_fe_model.py Added a comprehensive workflow for feature engineering and model registration.
notebooks/mlflow_experiment.json New JSON file defining an MLflow experiment with metadata and attributes.
notebooks/model_version.json New JSON file containing metadata for a machine learning model.
notebooks/run_info.json New JSON file with structured information about a specific MLflow run.
project-config.yml Updated parameters and added new fields in the project configuration.
pyproject.toml Significant modifications including project name change, exact version dependencies, and new build system section.
src/main.py Refactored run function to streamline configuration loading and preprocessing logic.
src/mlflow_train.py Introduced functionality for integrating MLFlow with a model for hotel reservation predictions.
src/packages/classifier.py Added CancellationModel class for classification tasks with various methods for prediction and evaluation.
src/packages/config.py Created ProjectConfig class for structured project configuration management.
src/packages/paths.py Modified AllPaths class to improve configuration handling and environment adaptability.
src/packages/preprocessing.py Updated Preprocessor class with new methods and improved data handling capabilities.
src/prepare_dataset.py Introduced a preprocessing module for hotel reservation data using Spark and Pandas.

Possibly related PRs

  • Dev #3: The changes in the .gitignore file in the retrieved PR include adding the entry prototype, which is directly related to the modification in the main PR where the line -prototype was removed, allowing the prototype directory to be tracked.

Suggested reviewers

  • basakeskili

Poem

In the meadow where data flows,
A rabbit hops where the ML grows.
With models logged and metrics bright,
We dance with joy in the moonlit night.
From prototypes to experiments grand,
Together we build, a data-driven band! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cremerf cremerf closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant