Make _MiddlewareFactory compatible with Callable #2768
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make
app
a positional-only argument so that aCallable[[ASGIApp, ...], ASGIApp]
can be passed in place of_MiddlewareFactory
.We can also consider making
_MiddlewareFactory
and moving it intostarlette.types
. This will make it easier to type arguments foradd_middleware()
.Checklist