Defer scope["starlette.exception_handlers"] in wrap_app_handling_exceptions
#2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Kludex
commented
Oct 13, 2024
Kludex
commented
- Related to getting "starlette.middleware.exceptions:ExceptionMiddleware.__call__" in API fastapi/fastapi#12416
…p_handling_exceptions`
Kludex
changed the title
conn.scope["starlette.exception_handlers"] access in wrap_app_handling_exceptions\conn.scope["starlette.exception_handlers"] access in wrap_app_handling_exceptions
Kludex
changed the title
conn.scope["starlette.exception_handlers"] access in wrap_app_handling_exceptionsscope["starlette.exception_handlers"] access in wrap_app_handling_exceptions
Kludex
changed the title
scope["starlette.exception_handlers"] access in wrap_app_handling_exceptionsscope["starlette.exception_handlers"] in wrap_app_handling_exceptions
|
Waiting for @harshit-2115 benchmarks. |
…when-exception-happens
|
Close since there was no follow-up. |
Kludex
deleted the
move-read-of-starlette.exceptions-handler-when-exception-happens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.