docs: Use with
to open files in multipart examples
#3478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While reading the docs for multipart file uploads, I wrongly assumed
httpx
will take care of closing the uploaded files because it was not done manually in the examples. Of course, I understand that the docs never stated this and closing files is usually a caller's responsibility, but I think it's still a good idea to make the examples more practical and less prone to confusion.Checklist