Add unaccent to SearchFilter
#9385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaligniana
force-pushed
the
add-unaccent-to-search-filter
branch
from
3a71f9b
to
f8825ba
Compare
mgaligniana
changed the title
unaccent to SearchFilter (based on #7733)unaccent to SearchFilter
mgaligniana
force-pushed
the
add-unaccent-to-search-filter
branch
from
f8825ba
to
2ff3f77
Compare
mgaligniana
force-pushed
the
add-unaccent-to-search-filter
branch
from
2ff3f77
to
a2bb1fb
Compare
|
Hi @auvipy! In case I would like to add a postgres db creation step, to be able to add new tests: should I add a step here |
|
I move this PR to Thank you! |
|
Tried this locally and the unaccent works great. It got me thinking though: anyone using |
mgaligniana
force-pushed
the
add-unaccent-to-search-filter
branch
from
a2bb1fb
to
f195dec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on discussion #7759 I've created this PR to continue the work made in #8775 and #7733
There are no tests with PostgreSQL but I'm creating this to test with the CI