Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-1011: Fixed storybook-utils eslint and prettier lint rules to not conflict #91

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

stanca-pop-lgp
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Storybook-utils's eslint rules and prettier lint rules are opposite for applying spacing after function keyword. Currently a workaround was applied to avoid the conflicts.

Resolution

I have reverted the code before the workaround intended to avoid lint warnings. The fix will be applied in enactjs/eslint-config-enact#93.

Additional Considerations

Links

WRR-1011

Comments

Enact-DCO-1.0-Signed-off-by: Stanca Pop [email protected]

Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants