Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-14835: TooltipDecorator to hide a tooltip when tapping outside of disabled components #1789

Open
wants to merge 5 commits into
base: release/2.9.x.develop
Choose a base branch
from

Conversation

0x64
Copy link
Member

@0x64 0x64 commented Dec 24, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

After tapping a disabled component with a tooltip once, a tooltip does not disappear even by tapping other components or empty space. This issue occurs only by touch inputs.

Resolution

There was a bug that show a tooltip again after hiding only for disabled components. I fixed the logic not to show again a tooltip.

Additional Considerations

Links

WRR-14835

Comments

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])

0x64 added 3 commits December 23, 2024 17:39
… components

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (dfff553) to head (bdee965).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           release/2.9.x.develop    #1789      +/-   ##
=========================================================
- Coverage                  80.91%   80.91%   -0.01%     
=========================================================
  Files                        148      148              
  Lines                       6697     6696       -1     
  Branches                    1995     1995              
=========================================================
- Hits                        5419     5418       -1     
  Misses                       970      970              
  Partials                     308      308              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

0x64 added 2 commits December 26, 2024 16:15
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant