Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-13724: Converted DebounceDecorator to functional component #1784

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ion-andrusciac-lgp
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Converted DebounceDecorator to functional component

Resolution

Additional Considerations

Links

WRR-13724

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac [email protected]

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.08%. Comparing base (5e803d7) to head (328317e).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1784      +/-   ##
===========================================
+ Coverage    80.87%   81.08%   +0.20%     
===========================================
  Files          148      148              
  Lines         6676     6771      +95     
  Branches      1989     2041      +52     
===========================================
+ Hits          5399     5490      +91     
- Misses         969      975       +6     
+ Partials       308      306       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x64
Copy link
Member

0x64 commented Dec 23, 2024

Note:

  • In this PR, we tries to convert a stateful HoC to a stateless HoC based on hooks so that the PR is resolving an issue of closure that occurs while we handle a state. Still, there is a small concern that the existing job is canceled when props is updated but we can handle it also if we really use this PR.
  • For a reference purpose, I suggested to keep this PR even we don't merge this into our stable branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants