WRR-4833: Make pageIndicatorPosition prop in PageViews component public #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1757 +/- ##
========================================
Coverage 80.87% 80.87%
========================================
Files 148 148
Lines 6676 6676
Branches 1989 1989
========================================
Hits 5399 5399
Misses 969 969
Partials 308 308 ☔ View full report in Codecov by Sentry. |
Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
|
@juwonjeong, Please resolve the merge conflict. |
MikyungKim
reviewed
Dec 9, 2024
Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
MikyungKim
reviewed
Dec 11, 2024
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ The following is a curated list of changes in the Enact sandstone module, newest | |||
| ### Added | |||
|
|
|||
| - `sandstone/Icon` supported icon list, adding new icon `calibration` | |||
| - `sandstone/Pageviews` `pageIndicatorPosition` prop to provide a way to determine where to place the page indicator | |||
There was a problem hiding this comment.
Suggested change
| - `sandstone/Pageviews` `pageIndicatorPosition` prop to provide a way to determine where to place the page indicator | |
| - `sandstone/Pageviews` `pageIndicatorPosition` prop to set the position of the page indicator |
Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
SkylerBaek
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
Checklist
Issue Resolved / Feature Added
Make
pageIndicatorPositionprop in PageViews component public as UX guide is updated.Resolution
Updated docs and sampler
Added changelog
Additional Considerations
Links
WRR-4833
Comments