-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-1966: Storybook - Read custom colors from luna settings service #1610
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1610 +/- ##
========================================
Coverage 81.59% 81.59%
========================================
Files 148 148
Lines 6673 6673
Branches 1986 1986
========================================
Hits 5445 5445
Misses 935 935
Partials 293 293 ☔ View full report in Codecov by Sentry. |
samples/sampler/colors-toolbar/CustomStoryDecorator.module.less
Outdated
Show resolved
Hide resolved
I believe that @enact/webos should be added as dependency in package.json of samplers. |
samples/sampler/colors-toolbar/CustomStoryDecorator.module.less
Outdated
Show resolved
Hide resolved
In general, I want to remove hard-coded color values as many as possible so that we need to take care of minimal parts when the default color is updated by design changes. Also, if our color generation/matching logic do not alter some colors from the default theme's colors, it looks better not to override them with the default values because Sandstone can use the default colors when nothing is specified in CSS variables. |
Good job! As we don't merge this PR right now, I converted this PR to a draft PR but it will be a good reference when we add a new features later. Thank you. |
Checklist
Issue Resolved / Feature Added
Implement custom theme feature to storybook
Running on webos environment: read and update colors with LS2Request
Running on PC: Added custom toolbars which render a built-in HTML color picker that updates components' style
https://storybook.js.org/docs/addons/writing-addons
https://storybook.js.org/docs/essentials/toolbars-and-globals
Resolution
Additional Considerations
Links
WRQ-1966
Comments
Enact-DCO-1.0-Signed-off-by: Adrian Cocoara [email protected]