-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-28042: Update dependencies' major versions #353
base: develop
Are you sure you want to change the base?
Conversation
@@ -70,7 +70,7 @@ | |||
"file-loader": "^6.2.0", | |||
"filesize": "^10.1.2", | |||
"fs-extra": "^11.2.0", | |||
"glob": "^10.4.2", | |||
"glob": "^11.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update this urgently? It will change the mininum node version to v20.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not urgently but the current webOS build supports node 20.12.2, so I think this change seemed to be possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the minimum node version accordingly.
package.json
Outdated
@@ -110,6 +110,9 @@ | |||
"webpack": "^5.93.0", | |||
"webpack-dev-server": "^5.0.4" | |||
}, | |||
"overrides": { | |||
"postcss": "^8.4.39" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find why we should do like this for which module update.
Could you be more specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I updated in PR description
I'm sorry the review got delayed a lot. Would you please resolve the merge conflict and update moduels to the latest? |
Checklist
Issue Resolved / Feature Added
Update dependencies' major versions
Resolution
Update dependencies' major versions
Additional Considerations
additionalAliases
option innode-polyfill-webpack-plugin
This feature can update the 3rd party modules' submodule version.
@testing-library/react
^15.0.6 → ^16.1.0 (https://github.com/testing-library/react-testing-library/releases/tag/v16.0.0)This reduces the chance of having conflicting versions of @testing-library/dom installed that frequently caused bugs when used with @testing-library/user-event.
css-minimizer-webpack-plugin
^6.0.0 → ^7.0.0 (https://github.com/webpack-contrib/css-minimizer-webpack-plugin/releases)dotenv-expand
^11.0.6 → ^12.0.1 (https://github.com/motdotla/dotenv-expand/blob/master/CHANGELOG.md#1200-2024-11-16)glob
^10.4.2 → ^11.0.0 (https://github.com/isaacs/node-glob/blob/main/changelog.md#110)node-polyfill-webpack-plugin
^3.0.0 → ^4.0.0 (https://github.com/Richienb/node-polyfill-webpack-plugin/releases/tag/v4.0.0)postcss-normalize
^10.0.1 → ^13.0.1 (https://github.com/csstools/postcss-normalize/blob/main/CHANGELOG.md)postcss-preset-env
^9.5.15 → ^10.1.3 (https://github.com/csstools/postcss-plugins/wiki/PostCSS-Preset-Env-10)sass-loader
^14.2.1 → ^16.0.4 (https://github.com/webpack-contrib/sass-loader/releases/tag/v16.0.0)validate-npm-package-name
^5.0.1 → ^6.0.0 (https://github.com/npm/validate-npm-package-name/releases/tag/v6.0.0)Links
WRQ-28042
Comments
Enact-DCO-1.0-Signed-off-by: Taeyoung Hong ([email protected])