Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-28042: Update dependencies' major versions #353

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

hong6316
Copy link
Contributor

@hong6316 hong6316 commented Aug 14, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Update dependencies' major versions

  • @testing-library/react ^15.0.6 → ^16.1.0
  • css-minimizer-webpack-plugin ^6.0.0 → ^7.0.0
  • dotenv-expand ^11.0.6 → ^12.0.1
  • glob ^10.4.2 → ^11.0.0
  • node-polyfill-webpack-plugin ^3.0.0 → ^4.1.0
  • postcss-normalize ^10.0.1 → ^13.0.1
  • postcss-preset-env ^9.5.15 → ^10.1.3
  • sass-loader ^14.2.1 → ^16.0.4
  • validate-npm-package-name ^5.0.1 → ^6.0.0

Resolution

Update dependencies' major versions

  • @testing-library/react ^15.0.6 → ^16.1.0
  • css-minimizer-webpack-plugin ^6.0.0 → ^7.0.0
  • dotenv-expand ^11.0.6 → ^12.0.1
  • glob ^10.4.2 → ^11.0.0
  • node-polyfill-webpack-plugin ^3.0.0 → ^4.1.0
  • postcss-normalize ^10.0.1 → ^13.0.1
  • postcss-preset-env ^9.5.15 → ^10.1.3
  • sass-loader ^14.2.1 → ^16.0.4
  • validate-npm-package-name ^5.0.1 → ^6.0.0

Additional Considerations

  • Apply additionalAliases option in node-polyfill-webpack-plugin
  // From `node-polyfill-webpack-plugin` v4, this module stop polyfilling 
  // `console`, `domain`, `process`, and internal `stream` modules by default.
  // For screenshot tests, Enact CLI still need to polyfill them so `additionalAliases` option added.
  new NodePolyfillPlugin({
    additionalAliases: ['console', 'domain', 'process', 'stream']
  }),
  "overrides": {
    "postcss": "^8.4.47"
    // `postcss` is used in the `postcss-global-import` module.
    // This module version published 6 years ago and there's no plan to update.
    // Instead, we install `"postcss": "^8.4.47"` for the workaround in `@enact/cli`.
  },

Links

WRQ-28042

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong ([email protected])

@@ -70,7 +70,7 @@
"file-loader": "^6.2.0",
"filesize": "^10.1.2",
"fs-extra": "^11.2.0",
"glob": "^10.4.2",
"glob": "^11.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update this urgently? It will change the mininum node version to v20.

Copy link
Contributor Author

@hong6316 hong6316 Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not urgently but the current webOS build supports node 20.12.2, so I think this change seemed to be possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the minimum node version accordingly.

package.json Outdated
@@ -110,6 +110,9 @@
"webpack": "^5.93.0",
"webpack-dev-server": "^5.0.4"
},
"overrides": {
"postcss": "^8.4.39"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find why we should do like this for which module update.
Could you be more specific?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I updated in PR description

@MikyungKim
Copy link
Contributor

I'm sorry the review got delayed a lot. Would you please resolve the merge conflict and update moduels to the latest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants