Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-11138: Fixed Slider and IncrementSlider knob alignment in Electro skin #820

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ion-andrusciac-lgp
Copy link
Contributor

@ion-andrusciac-lgp ion-andrusciac-lgp commented Dec 5, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Fixed Slider and IncrementSlider knob alignment in Electro skin

Resolution

Additional Considerations

The same behavior was observed on IncrementSlider too and was fixed

Links

WRR-11138

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac [email protected]

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.00%. Comparing base (dfe0a11) to head (0e24abc).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #820   +/-   ##
========================================
  Coverage    85.00%   85.00%           
========================================
  Files          118      118           
  Lines         4435     4435           
  Branches      1225     1225           
========================================
  Hits          3770     3770           
  Misses         512      512           
  Partials       153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants