Add support for other countries #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- User defined phone number formats supportted. - Raw support (no formatting) supported. - Handles variable length phone numbers. - Closes #112
…er formats. - Now using a common method to strip phone numbers of non-alphanumeric chars. - Removed input pattern mask from the Add Permitted Number and Add Blocked Number dialogs. - Displaying phone number format string in dialogs for guidance only. - closes #111
- Ensures phone numbers use uppercase alpha chars. - Alpha chars now allowed in search phone number. - Closes #114
- Added the BLOCK_SERVICE to the configuration. Permitted values are "NOMOROBO" and "" (blank). - Cleaned up the logging during testing. - Closes #113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for other countries with the following changes:
PHONE_DISPLAY_FORMATandPHONE_DISPLAY_SEPARATOR)PHONE_DISPLAY_FORMATare handled)BLOCK_SERVICE). The default is enabled. Countries other than the USA should set this value to""(blank) to disable the use of the lookup service.Fixes #99
Fixes #111
Fixes #112
Fixes #113
Fixes #114