Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed numerous broken resources from README #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ebennetteng
Copy link

Broken links removed and new resource added, thank you

Broken links removed and new resource added, thank you
@Ebennetteng Ebennetteng changed the title Update README.md Removed numerous broken resources from README Dec 21, 2021
@AkechiShiro
Copy link

Why wasn't this PR accepted ?

@AkechiShiro
Copy link

@emtuls ?

@emtuls
Copy link
Owner

emtuls commented Jan 19, 2024

@AkechiShiro @Ebennetteng I haven't checked this in a long time, and never expected it to really be used by many people! Sorry about that.

My typical process is using the .html as a list of bookmarks that is imported into the browser, which is way more up to date and organized compared to the README.md style list of links, and any updates to the README.md should attempt to replace broken links with a suitable replacement (at the very least, try archive.org and find an old version). Most links break because there is a new home for the original link or because there is a more up to date version, so finding those and replacing the broken link with that is much better than removing the link outright.

I will make some suggestions to this PR as an example, as I've already found a few cases where this can be applied.

Just for note, the README.md is VERY out of date and has not kept up with any of the 1000+ newly added bookmarks and reorganizations that I've done.

@AkechiShiro
Copy link

I think there should be two easy upgrade, a GitHub Actions that parses the bookmark, does a HTTP request to the website and a nslookup to check if still alive.

And update the bookmark.html file according to results

@emtuls
Copy link
Owner

emtuls commented Jan 19, 2024

That would be nice to consider! It might work better parsing the .html first and having it update the README.md, as that is MUCH more up to date and has many more links in it.

If you've got the extra cycles to help with that, I'd be open to it. I'm a bit tied up with many other things at the moment. 😊

@@ -40,8 +40,6 @@ Bookmarks

[Offensive Security 2013 - FSU - Lecture5: Reverse Engineering (x86) Workshop Day 1 - YouTube](https://www.youtube.com/watch?v=Pg8bmV9vcKg&feature=youtu.be)

[Offensive Computer Security Home Page Spring 2014](http://www.cs.fsu.edu/~redwood/OffensiveComputerSecurity/)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be replaced with the lecture playlist on youtube: https://www.youtube.com/playlist?list=PLl2ZIjyGEWWVYUeYLTkanteQo4BPephik

@@ -174,8 +172,6 @@ Bookmarks

[CS50's Introduction to Computer Science | edX](https://www.edx.org/course/cs50s-introduction-computer-science-harvardx-cs50x)

[CS50](https://cs50.harvard.edu/2018/fall/)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS50 is a legendary course, it should definitely not be removed, as it is constantly updated each year.

Instead, we can add a link to some of the lectures or their youtube page which hosts the lectures each year:
2023 lectures: https://www.youtube.com/playlist?list=PLhQjrBD2T380F_inVRXMIHCqLaNUd7bN4
YT Page: https://www.youtube.com/channel/UCcabW7890RKJzL968QWEykA

@@ -280,6 +276,12 @@ Bookmarks

</dl>

<dl>

[What is CMMC?](https://logit.io/blog/post/what-is-cmmc)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a very useful link. It seems more like an advertisement for a website that I do not endorse.

@@ -564,8 +566,6 @@ Bookmarks

[ObjectOrientedProgramminginC4thEdition.pdf](https://fac.ksu.edu.sa/sites/default/files/ObjectOrientedProgramminginC4thEdition.pdf)

[CPP_v1.1.pdf](https://ms.sapientia.ro/~manyi/teaching/c++/CPP_v1.1.pdf)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing this, we can use a link to the PDF on web.archive.org: https://web.archive.org/web/20200108080903/https://ms.sapientia.ro/~manyi/teaching/c++/CPP_v1.1.pdf

@@ -956,8 +956,6 @@ Bookmarks

<dl>

[Easy x86-64](http://ian.seyler.me/easy_x86-64/)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1030,8 +1028,6 @@ Bookmarks

[Full Stack Book: crash-course-django](https://github.com/codexplore-io/crash-course-django)

[Super Crash Course in Full Stack Web Development with Python and Django](http://www.codexplore.io/books/crash-course/)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link does not seem to work

@@ -1060,8 +1056,6 @@ Bookmarks

[Learn Shell Programming - Free Interactive Shell Programming Tutorial](http://www.learnshell.org/)

[The Bash Guide](https://guide.bash.academy/)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link still works, not sure why there is a suggestion to remove it?

It could have been down temporarily, but it is active now.

@@ -1150,14 +1144,10 @@ Bookmarks

<dl>

[CS50](https://cs50.harvard.edu/2018/fall/)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the previous link for this:

CS50 is a legendary course, it should definitely not be removed, as it is constantly updated each year.

Instead, we can add a link to some of the lectures or their youtube page which hosts the lectures each year:
2023 lectures: https://www.youtube.com/playlist?list=PLhQjrBD2T380F_inVRXMIHCqLaNUd7bN4
YT Page: https://www.youtube.com/channel/UCcabW7890RKJzL968QWEykA

[CS50's Introduction to Computer Science | edX](https://www.edx.org/course/cs50s-introduction-computer-science-harvardx-cs50x)

[CS50 - Reference](https://reference.cs50.net/)

[Introduction to Game Development](https://cs50.github.io/games/)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1746,8 +1736,6 @@ Bookmarks

[Georgia Tech - High Performance Computer Architecture - Udacity](https://classroom.udacity.com/courses/ud007)

[MIT - Comp Org, Arch, and Digital Design](https://6004.mit.edu/web/spring19/course_information)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be a suitable replacement: https://ocw.mit.edu/courses/6-004-computation-structures-spring-2017/

@@ -2192,8 +2180,6 @@ Bookmarks

[Linux Device Drivers, 3rd Edition: Jonathan Corbet, Alessandro Rubini, Greg Kroah-Hartman: 9780596005900: Amazon.com: Books](https://www.amazon.com/Linux-Device-Drivers-Jonathan-Corbet/dp/0596005903/ref=sr_1_4?ie=UTF8&qid=1483650712&sr=8-4&keywords=understanding+linux+kernel)

[Linux Kernel Teaching — The Linux Kernel documentation](https://linux-kernel-labs.github.io/master/)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link has been updated to this: https://linux-kernel-labs.github.io/refs/heads/master/

@@ -2308,8 +2294,6 @@ Bookmarks

<dl>

[IS651 | Distributed Systems](https://userpages.umbc.edu/~jianwu/is651/651.syll.s18.html)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would make for a suitable replacement: https://sduan.informationsystems.umbc.edu/classes/IS651/

@@ -2546,8 +2530,6 @@ Bookmarks

[9.520/6.860, Fall 2017](http://www.mit.edu/~9.520/fall17/)

[Stanford University: Tensorflow for Deep Learning Research](http://web.stanford.edu/class/cs20si/index.html)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is still active, so I'm not sure why it should be removed?

It could have been down temporarily at the time, but it is up now.

@@ -3956,8 +3938,6 @@ Bookmarks

[Malware Unicorn 101](https://securedorg.github.io/RE101/)

[Malware Unicorn 102](https://securedorg.github.io/RE102/)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -3956,8 +3938,6 @@ Bookmarks

[Malware Unicorn 101](https://securedorg.github.io/RE101/)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be replaced, and with https://malwareunicorn.org/workshops/re101.html#0

Copy link
Owner

@emtuls emtuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added comments to each of your suggestions. Please look at them and make the changes if you would still link for this to be merged in. 🙂

@AkechiShiro
Copy link

AkechiShiro commented Jan 19, 2024

Sure will try and fork and work on a CI for this @emtuls
Thanks a lot for taking the time to review this PR

@emtuls emtuls force-pushed the master branch 2 times, most recently from 4fe3526 to 94b9059 Compare March 15, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants