Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wifi Reconnect #2207 #2208

Merged
merged 20 commits into from
Nov 16, 2024
Merged

Wifi Reconnect #2207 #2208

merged 20 commits into from
Nov 16, 2024

Conversation

proddy
Copy link
Contributor

@proddy proddy commented Nov 15, 2024 •
edited
Loading

MichaelDvP
MichaelDvP approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@MichaelDvP MichaelDvP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing: You show wificonnects: 0 in heartbeat. It should be named reconnects or count the first connect too. The mqttconnects starts with first connect 1.
So in my heartbeat it shows mqttconnects=1 and wificonnects=0.

@proddy
Copy link
Contributor Author

proddy commented Nov 15, 2024

One thing: You show wificonnects: 0 in heartbeat. It should be named reconnects or count the first connect too. The mqttconnects starts with first connect 1. So in my heartbeat it shows mqttconnects=1 and wificonnects=0.

yes, you're right. I'll update.

@proddy proddy merged commit da77d52 into emsesp:dev Nov 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDvP MichaelDvP MichaelDvP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proddy @MichaelDvP