Skip to content

Commit

Permalink
Fixed rare segmentationFault on startup
Browse files Browse the repository at this point in the history
Still TODO in context_table_proxy_model.cpp in filterAcceptRows.
  • Loading branch information
HerrKermet committed Sep 26, 2023
1 parent 1db3dd1 commit f97c21f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ namespace hal

bool ContextTableProxyModel::filterAcceptsRow(int source_row, const QModelIndex& source_parent) const
{
QList<int> columns = mSearchOptions.getColumns();

//TODO somehow the program crashes with segfault if this method ever returns a false at the initial start
QList<int> columns = mSearchOptions.getColumns();

//TODO get column count
if(columns.empty()){
Expand Down
2 changes: 1 addition & 1 deletion plugins/gui/src/searchbar/search_proxy_model.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
namespace hal {
SearchProxyModel::SearchProxyModel(QObject* parent): QSortFilterProxyModel(parent)
{
mSearchOptions = SearchOptions();
mSearchOptions = SearchOptions(8);
}

void SearchProxyModel::startSearch(QString text, int options)
Expand Down

0 comments on commit f97c21f

Please sign in to comment.