bugfix: opening external data in waveform-viewer only once

emsec · May 22, 2024 · 5f601df · 5f601df
1 parent 2d84266
commit 5f601df
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/plugins/simulator/waveform_viewer/include/waveform_viewer/waveform_viewer.h b/plugins/simulator/waveform_viewer/include/waveform_viewer/waveform_viewer.h
@@ -123,6 +123,7 @@ namespace hal
 
     private:
         bool mVisualizeNetState;
+        bool mOwnershipRequired;
 
         QAction* mCreateControlAction;
         QAction* mSimulSettingsAction;

diff --git a/plugins/simulator/waveform_viewer/src/waveform_viewer.cpp b/plugins/simulator/waveform_viewer/src/waveform_viewer.cpp
@@ -59,7 +59,7 @@ namespace hal
 
     WaveformViewer::WaveformViewer(QWidget *parent)
         : ExternalContentWidget("waveform_viewer","WaveformViewer",parent),
-          mVisualizeNetState(false), mCurrentWaveWidget(nullptr)
+          mVisualizeNetState(false), mOwnershipRequired(false), mCurrentWaveWidget(nullptr)
     {
         LogManager::get_instance()->add_channel(std::string("waveform_viewer"), {LogManager::create_stdout_sink(), LogManager::create_file_sink(), LogManager::create_gui_sink()}, "info");
         mCreateControlAction = new QAction(this);
@@ -366,6 +366,9 @@ namespace hal
 
     void WaveformViewer::handleControllerAdded(u32 controllerId)
     {
+        // nothing to do here, viewer will open widget when taking over ownership
+        if (mOwnershipRequired) return;
+
         // check whether controller already added
         for (int inx=0; inx<mTabWidget->count(); inx++)
         {
@@ -406,8 +409,10 @@ namespace hal
             NetlistSimulatorControllerPlugin* ctrlPlug = static_cast<NetlistSimulatorControllerPlugin*>(plugin_manager::get_plugin_instance("netlist_simulator_controller"));
             if (ctrlPlug)
             {
+                mOwnershipRequired = true;
                 std::unique_ptr<NetlistSimulatorController> ctrlRef = ctrlPlug->restore_simulator_controller(gNetlist,filename.toStdString());
                 takeControllerOwnership(ctrlRef, true);
+                mOwnershipRequired = false;
             }
         }
         else if (mCurrentWaveWidget && mCurrentWaveWidget->controller()->can_import_data() && filename.toLower().endsWith(".vcd"))