Use str.isascii #23378
Open
Use str.isascii #23378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Jan 13, 2025
| @@ -476,17 +476,6 @@ def check_closure_compiler(cmd, args, env, allowed_to_fail): | |||
| return True | |||
|
|
|||
|
|
|||
| # Remove this once we require python3.7 and can use std.isascii. | |||
| # See: https://docs.python.org/3/library/stdtypes.html#str.isascii | |||
There was a problem hiding this comment.
If you are proposing we drop support for python3.6 can you open a bug for that where we can discuss the costs/benefits?
|
I created an issue to discuss bumping the minimum supported python version: #23387 |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 15, 2025
The reason for picking 3.9 here is that it provides all the features we currently have need of, and it available in the places we care about: - debian/stable (bookworm): 3.11 - ubuntu/LTS (jammy): 3.10 - emsdk: 3.9.2 It also seems like a good idea to choose the emsdk version since that is the version we use for testing and we don't currently have any mechanism to test on anything older than that (which means we currently lack any way to confirm that we really do support 3.6). Replaces: emscripten-core#23378 Fixes: emscripten-core#23387
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 15, 2025
The reason for picking 3.9 here is that it provides all the features we currently have need of, and it available in the places we care about: - debian/stable (bookworm): 3.11 - ubuntu/LTS (jammy): 3.10 - emsdk: 3.9.2 It also seems like a good idea to choose the emsdk version since that is the version we use for testing and we don't currently have any mechanism to test on anything older than that (which means we currently lack any way to confirm that we really do support 3.6). Replaces: emscripten-core#23378 Fixes: emscripten-core#23387
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 15, 2025
The reason for picking 3.9 here is that it provides all the features we currently have need of, and it available in the places we care about: - debian/stable (bookworm): 3.11 - ubuntu/LTS (jammy): 3.10 - emsdk: 3.9.2 It also seems like a good idea to choose the emsdk version since that is the version we use for testing and we don't currently have any mechanism to test on anything older than that (which means we currently lack any way to confirm that we really do support 3.6). Replaces: emscripten-core#23378 Fixes: emscripten-core#23387
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 15, 2025
The reason for picking 3.8 here is that it provides all the features we currently have need of, and it available in the places we care about: - debian/stable (bookworm): 3.11 - ubuntu/LTS (focal): 3.8 - emsdk: 3.9.2 Replaces: emscripten-core#23378 Fixes: emscripten-core#23387
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 15, 2025
The reason for picking 3.8 here is that it provides all the features we currently have need of, and it available in the places we care about: - debian/stable (bookworm): 3.11 - ubuntu/LTS (focal): 3.8 - emsdk: 3.9.2 Replaces: emscripten-core#23378 Fixes: emscripten-core#23387
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 15, 2025
The reason for picking 3.8 here is that it provides all the features we currently have need of, and it available in the places we care about: - debian/stable (bookworm): 3.11 - ubuntu/LTS (focal): 3.8 - emsdk: 3.9.2 Replaces: emscripten-core#23378 Fixes: emscripten-core#23387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Ubuntu focal is the oldest version supported by emscripten and it packages Python 3.8.2, I think it'd be safe to replace
isascii.https://launchpad.net/ubuntu/focal/+package/python3