Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight region boundaries #85

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Highlight region boundaries #85

merged 5 commits into from
Apr 18, 2024

Conversation

henhuy
Copy link
Contributor

@henhuy henhuy commented Apr 18, 2024

Closes #48

Steps to set it up:

  • migrate
  • make load_data

@henhuy henhuy linked an issue Apr 18, 2024 that may be closed by this pull request
@henhuy henhuy self-assigned this Apr 18, 2024
@henhuy henhuy marked this pull request as ready for review April 18, 2024 08:12
@henhuy henhuy requested a review from nesnoj April 18, 2024 08:13
Copy link
Contributor

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @henhuy, looks better now!
I reduced the line width a bit.

One thing: the region boundary is displayed above the mun names, I tried to change the layer order in layer_styles to have it in the background but that's not working..can this be changed easily?

@henhuy
Copy link
Contributor Author

henhuy commented Apr 18, 2024

Moved region boundary layer to bottom

@henhuy henhuy requested a review from nesnoj April 18, 2024 10:57
Copy link
Contributor

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@henhuy henhuy merged commit 349cd8a into dev Apr 18, 2024
1 check passed
@henhuy henhuy deleted the clearer_region_boundaries branch April 18, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always show region boundaries
3 participants