Improve result charts with arrow indicator #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesnoj
reviewed
May 2, 2024
There was a problem hiding this comment.
Looks good!
And thanks for the layout changes which I like, I slightly changed some values as I found the charts to be a little small.
One question: It is working but jshint complains about MutationObserver not being defined - but it's a build-in object, isn't it?
It's a built-in browser API, so I don't know why it's not recognizing it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, I used the opportunity to improve a bit the chart layouts. The chart legend items were sometimes overlapping. I also added more space between the charts to make it more readable.
close #114