-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/results calculation user feedback #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
I can see the elements as described, also HTML works now in tooltips.
@henhuy should give this a check too.
Next step is to wire the progress bar and charts to the rest..
e304b92
to
f00c42c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great blinky stuff, cheers!
I commented-out progress bar as it's not wired yet, new issue: #132
Fixes #95
Fixes #88
I implemented the mockups from #95 without functionality:
.panel-item__calc-alert
CSS class for normal loading (green).panel-item__calc-alert.panel-item__calc-alert--error
CSS classes if error (red)The issue from #88 was also a problem here, so I kind of fixed it. I mean kind of, because the arrow of all the tooltips was not placed correctly (you can see this in the screenshot from #88) and I couldn't find a way to fix it, so I decided to simply remove it. I think it works okay. But feel free to check for a solution if you want to. I just didn't want to spend so much time on it as I don't see this as urgent.
@nesnoj
const tooltipList = [...tooltipTriggerList].map(tooltipTriggerEl => new bootstrap.Tooltip(tooltipTriggerEl, {html: true}))
So it should be possible to add
<br>