Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/add third slider mark #103

Merged
merged 4 commits into from
May 1, 2024
Merged

Improve/add third slider mark #103

merged 4 commits into from
May 1, 2024

Conversation

josihoppe
Copy link
Contributor

third slider marks can be added in the energy_panel and heat_panel jsons in data/digipipe/settings

names for sliders are atm:
status_quo -> Heute
future_scenario_2030 -> BB2030
future_scenario_2040 -> BB2040

@josihoppe josihoppe linked an issue Apr 29, 2024 that may be closed by this pull request
@josihoppe
Copy link
Contributor Author

josihoppe commented Apr 29, 2024

@henhuy I saw that the slider marks are also used here:

def get_capacities_from_sliders(year: int) -> pd.Series:

that function is being called by electricity_overview

def electricity_overview(year: int) -> pd.Series:
and get_regional_independency
def get_regional_independency(simulation_id: int) -> tuple[int, int, int, int]:

both are documented that they only take 2022 or 2045 as an input for "year". Would the new slider mark also effect that?

@nesnoj nesnoj self-requested a review May 1, 2024 13:08
Copy link
Contributor

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this feature @josihoppe !
I tested some values and it's shown correctly. I shortened the scenario abbreviations to take less space.

Althought the target years differ and are somewhat misleading in the code now, it is ok to use the 2040 value here as it is the overall target. Thanks for bringing this up!

@nesnoj nesnoj merged commit 67903cb into dev May 1, 2024
1 check passed
@nesnoj nesnoj deleted the improve/add_third_slider_mark branch May 1, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add slider markers for 2030
2 participants