Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-result charts for PV and wind #101

Merged
merged 19 commits into from
May 2, 2024
Merged

Pre-result charts for PV and wind #101

merged 19 commits into from
May 2, 2024

Conversation

nesnoj
Copy link
Contributor

@nesnoj nesnoj commented Apr 25, 2024

Fixes #99

Adds first result charts for PV and wind. All results are pre-results.

@nesnoj nesnoj self-assigned this Apr 25, 2024
@nesnoj
Copy link
Contributor Author

nesnoj commented Apr 26, 2024

I added some draft wind+pv charts.
In the pv section, there are multiple rows with charts:
image

However, the user may not recognize this. @bmlancien, could you add something like an arrow to indicate that there's more content below (only shown when there actually is more)? This is lower prio, but maybe you have a quick solution..

(in this PR if you like)

@nesnoj
Copy link
Contributor Author

nesnoj commented Apr 26, 2024

@henhuy Please check if implementation is ok and format works out for you

@nesnoj nesnoj changed the title Feature/result charts1 Pre-result charts for PV and wind May 2, 2024
@nesnoj nesnoj requested review from henhuy and removed request for henhuy May 2, 2024 07:15
@nesnoj nesnoj marked this pull request as ready for review May 2, 2024 07:19
@nesnoj nesnoj requested a review from henhuy May 2, 2024 07:19
Copy link
Contributor

@henhuy henhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I will set up new issue for chart data calculation

@nesnoj
Copy link
Contributor Author

nesnoj commented May 2, 2024

LGTM I will set up new issue for chart data calculation

Thx!
And I'll open a new issue for indicator for more content in result charts

@nesnoj nesnoj merged commit 89df9c5 into dev May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add and rework result charts
2 participants