-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to paho-mqtt 2.0 #286
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
=======================================
+ Coverage 88.4% 88.5% +0.1%
=======================================
Files 6 6
Lines 432 438 +6
Branches 83 83
=======================================
+ Hits 382 388 +6
Misses 29 29
Partials 21 21 ☔ View full report in Codecov by Sentry. |
@empicano, @frederikaalund, this is ready for review. The commit Thus, we can merge this PR and close #279. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any comments, LGTM, good job 😎
Well done with this migration! 👍 I looked through the code and it looks good to me too. :) I like that you found some typing fixes for paho-mqtt as well. |
Thank you. |
Should we cut a release for this? |
Yeah, that is a good idea. 👍 We have to mention that we no longer support paho-mqtt 1.x in that one as well. I'm currently reviewing the #287, can you do a release? :) |
I can do this at noon. |
The tests are passing.
The typing need more work both in aiomqtt and in paho-mqtt upstream.