-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: client aenter connect error lock release #245
Conversation
Codecov Report
@@ Coverage Diff @@
## main #245 +/- ##
=======================================
+ Coverage 84.1% 84.7% +0.5%
=======================================
Files 4 4
Lines 468 472 +4
Branches 87 87
=======================================
+ Hits 394 400 +6
+ Misses 47 45 -2
Partials 27 27
|
ci relevant: snok/install-poetry#94 |
Hi there, Great that you put work into this, thank you! 😎 I believe the reason that the tests are failing is that the poetry dropped support for Python 3.7 in 1.6.0 rather than the issue you linked. See also your first commit, where all those workflows that use Python 3.7 fail, but not the others. Python 3.7 reached its end of life, so I think we can drop it anyways. I opened PR #246 to do that. Your PR looks good to me otherwise 🙂 |
When your PR is merged, I will merge it once. |
Looks good to me as well. 👍 I just reviewed #246 as well. |
5afa7f4
to
1058b6d
Compare
Thanks for another great contribution to aiomqtt, @vvanglro! 💪 |
fix: #244