Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chameo.ttl #14

Merged
merged 8 commits into from
Oct 23, 2024
Merged

Update chameo.ttl #14

merged 8 commits into from
Oct 23, 2024

Conversation

jsimonclark
Copy link
Collaborator

Added techniques that are essential for battery / electrochemical characterization:

  • DirectCurrentInternalResistance
  • EnergyDispersiveXraySpectroscopy
  • FourierTransformInfraredSpectroscopy
  • ThreePointBendingTest
  • BrunauerEmmettTellerMethod
  • MercuryPorosimetry
  • PotentiostaticIntermittentTitrationTechnique
  • PseudoOpenCircuitVoltageMethod
  • StaircaseGalvanostaticIntermittentTitrationTechnique
  • XrayDiffraction
  • XrayPowderDiffraction

Changed the IRI for GITT to GalvanostaticIntermittentTitrationTechnique

Added techniques for:
- DirectCurrentInternalResistance
- EnergyDispersiveXraySpectroscopy
- FourierTransformInfraredSpectroscopy
- ThreePointBendingTest
- BrunauerEmmettTellerMethod
- MercuryPorosimetry
- PotentiostaticIntermittentTitrationTechnique
- PseudoOpenCircuitVoltageMethod
- StaircaseGalvanostaticIntermittentTitrationTechnique
- XrayDiffraction
- XrayPowderDiffraction

Changed the IRI for GITT to GalvanostaticIntermittentTitrationTechnique
@jsimonclark jsimonclark added the enhancement New feature or request label Mar 28, 2024
@pierluigidelnostro
Copy link
Collaborator

pierluigidelnostro commented Apr 15, 2024

The classes below seem to be too specific to be subClassOf CharacterisationMethod

chameo:MercuryPorosimetry rdf:type owl:Class ;
rdfs:subClassOf chameo:CharacterisationMethod ;

chameo:BrunauerEmmettTellerMethod rdf:type owl:Class ;
rdfs:subClassOf chameo:CharacterisationMethod ;

if they cannot be grouped under an existing category of methods can you please suggest a new one?

@pierluigidelnostro
Copy link
Collaborator

pierluigidelnostro commented Jun 22, 2024

The classes below seem to be too specific to be subClassOf CharacterisationMethod

chameo:MercuryPorosimetry rdf:type owl:Class ; rdfs:subClassOf chameo:CharacterisationMethod ;

chameo:BrunauerEmmettTellerMethod rdf:type owl:Class ; rdfs:subClassOf chameo:CharacterisationMethod ;

if they cannot be grouped under an existing category of methods can you please suggest a new one?

@jsimonclark Any suggestions for a class to group those?

add grouping for MercuryPorosimetry and BrunauerEmmettTellerMethod
@jsimonclark
Copy link
Collaborator Author

@pierluigidelnostro , yes thanks for the reminder. I suggest to group them under Porosimetry in the following way:

CharacterisationMethod
└── Porosimetry
├── MercuryPorosimetry
└──GasAdsorptionPorosimetry
└── BrunauerEmmettTellerMethod

I have addd terms for Porosimetry and GasAdsorptionPorosimetry , and pushed these changes.

@jsimonclark
Copy link
Collaborator Author

@pierluigidelnostro , I resolved the conflicts with the main branch and fixed the issues that were causing emmo check to fail. Could you please have a look and merge if you agree?

@pierluigidelnostro pierluigidelnostro merged commit 0e6a92f into main Oct 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants