Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failures in rename_iris() #820

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Dec 12, 2024

Description

The --rename-iris is now actively used to generate emmo-for-humans.ttl.

Note: this PR is already in use for generation of https://w3id.org/emmo/emmo-for-humans, a version of EMMO that is only intended for examples which has all numerical IDs replaced with prefLabel's.
When merging this PR, please update the pip install EMMOntoPy statement in https://github.com/emmo-repo/EMMO/blob/master/.github/workflows/cd_update_pages.yml

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.89%. Comparing base (de542a3) to head (5c7ffe3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage   72.90%   72.89%   -0.01%     
==========================================
  Files          18       18              
  Lines        3790     3789       -1     
==========================================
- Hits         2763     2762       -1     
  Misses       1027     1027              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Describe what this PR is about so that it is possible to do an informed review.

Also, instead of commenting out tests, the code should be fixed so that they pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants