Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix for fact++ #817

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Minor fix for fact++ #817

merged 5 commits into from
Dec 11, 2024

Conversation

jesper-friis
Copy link
Collaborator

Description

Minor bugfix. Skip some additional datatypes when running FaCT++ and HermiT.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.90%. Comparing base (6a0a455) to head (522ff58).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ontopy/ontology.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #817   +/-   ##
=======================================
  Coverage   72.90%   72.90%           
=======================================
  Files          18       18           
  Lines        3790     3790           
=======================================
  Hits         2763     2763           
  Misses       1027     1027           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francescalb francescalb merged commit de542a3 into master Dec 11, 2024
11 of 12 checks passed
@francescalb francescalb deleted the run-fact++ branch December 11, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants