-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing rdfs schemas #814
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #814 +/- ##
==========================================
+ Coverage 72.90% 72.99% +0.09%
==========================================
Files 18 18
Lines 3790 3814 +24
==========================================
+ Hits 2763 2784 +21
- Misses 1027 1030 +3 ☔ View full report in Codecov by Sentry. |
francescalb
commented
Dec 11, 2024
jesper-friis
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially closes #811.
Closes #797
I is not possible to easily access classes of typ rdfs:Class. This is needed if working simultaneously with an rdf-schema (as opposed to an owl ontology). Owlready2 does not search for enties that are not of type owl:XXX.
A search for rdfs:Class is now added so that when asking for classes in an ontology also the rdfs:Class'es are returned as Python objects.
This is not as readily fixed with rdfs:Property. As a first fix, such properties are now returned as a list of strings (instead of a list of python objcets). Note that the nodes are present in the onotology, but the rdfs:Poerty is not cast as a python object.
Owlready2 is designed to support owl ontologies (not rdfs). If we really want to extend the suport for rdfs:Property the best solution is most likely to cast it to an owl:Annotation_property. If so this should be done in a next PR .